dApp: Remove an unnecessary condition for ethAccount in the deposit flow
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkosiorowska
force-pushed
the
fix-for-eth-wallet
branch
from
91df679 to
a40ba08
Compare
The `ethAccount` is no longer necessary for deposit flow.
kkosiorowska
force-pushed
the
fix-for-eth-wallet
branch
from
a40ba08 to
d9aa23a
Compare
The `ethAccount` is no longer needed for SDK and in the deposit flow.
kkosiorowska
changed the title
ethAccount in the deposit flow
r-czajkowski
previously approved these changes
May 29, 2024
There was a problem hiding this comment.
LGTM. Let's merge the #371 first and then I'll merge this PR.
Closed
r-czajkowski
approved these changes
May 29, 2024
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkosiorowska
changed the title
ethAccount in the deposit flowethAccount in the deposit flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #371
This PR removes the unnecessary check condition if the
ethAccountexists for deposit flow. The ETH account is no longer needed, so we should remove it from the wallet context. However, let's do it in a separate PR.Implemented solution
Screen.Recording.2024-05-28.at.11.24.07.mov